search

AJamesPhillips / DataCurator

DataCurator enables you to map and understand complex systems before helping you plan, communicate and navigate successful interventions in them.
https://DataCurator.org
8 stars 1 forks source link

Expired session refreshes but does not update user info #190

Closed AJamesPhillips closed 2 years ago

AJamesPhillips commented 2 years ago

Describe the bug

On returning to datacurator.org/app?storage_location=NN where NN is some base id I have access to, the page presented the Sign in / Register modal, and in the top left showed the "Sign in" option. But it also successfully loaded the base's component. On clicking the close button of the Sign in modal it still showed the components but also incorrectly showed "Sign in" in the top right.

To Reproduce

Steps to reproduce the behavior (maybe):

  1. Sign in to datacurator and open a base you have access to.
  2. Wait until the session expires (currently this is currently set to 604,800 seconds (one week))
  3. Refresh the page
  4. The page presented the Sign in / Register modal, and in the top left showed the "Sign in" option but in the background it also successfully loads the base's components.
  5. On clicking the close button of the Sign in modal the app shows the components of the base but does not show your user name in the top right.

Expected behavior

[ ] Should not display the "Sign in / register" modal until it is sure it can not refresh your current user session. [ ] Should update the user's information when it has successfully refreshed the supabase session info.

AJamesPhillips commented 2 years ago

This may now be fixed.

AJamesPhillips commented 2 years ago

Closing until is observed again.