search

AJamesPhillips / DataCurator

DataCurator enables you to map and understand complex systems before helping you plan, communicate and navigate successful interventions in them.
https://DataCurator.org
8 stars 1 forks source link

Calculate overlapping nodes better #212

Open AJamesPhillips opened 2 years ago

AJamesPhillips commented 2 years ago

Describe the bug

Two nodes which are not overlapping show the overlapping icon Two nodes which are overlapping do not show the overlapping icon

To Reproduce

Steps to reproduce the behavior:

  1. Create a node (double click on the canvas so it is positioned on the main horizontal and vertical increments)
  2. Create a second node to the right of it and move it left by 4 increments
  3. Select both and move them over by 6 small increments
  4. Observe the overlapping icon is present on both nodes despite them not overlapping

image

  1. Only moving them both left by only 4 does correctly not show the over lapping icon.

image

  1. Create the second node and move it left by 9 small increments to overlap the other.
  2. Observe it does not display the overlapping icon

image

  1. (Move them both left by 1 and observe the overlapping icon appears)

image

Expected behavior

Should only show the overlapping icon when they overlap.

Additional context

Would be great to factor in the node size as well (if this is not done already).