AJamesPhillips / DataCurator

DataCurator enables you to map and understand complex systems before helping you plan, communicate and navigate successful interventions in them.
https://DataCurator.org
8 stars 1 forks source link

Error when creating knowledge view for component of another base that already has a knowledge view #227

Open AJamesPhillips opened 2 years ago

AJamesPhillips commented 2 years ago

To Reproduce

Steps to reproduce the behavior:

  1. Create a component "1" in base A, and create a knowledge view for it, inside this knowledge view create a second component "2" and create a knowledge view for this.
  2. Change to base B and add component "1" to it, reload and click on it's knowledge view magnifying glass.
  3. Observe that whilst in editing mode, component "2"'s knowledge view magnifying glass symbol is present is blue (i.e. it is absent)
  4. Clicking on the magnifying glass will result in an unhandled error (will change to a different knowledge view that is empty)

Expected behavior

? Decide on expected behaviour. Is the magifying glass red?... then we'd need to attempt to load all knowledge views of all components that are from an existing base. If the magnying glass is blue, then we need to perhaps warn people that this component already has a knowledge view associated with it and offer them to change to that base, or to create a new component that wraps this component and create a knowledge view for that wrapper instead? Preferably there would be a way to formalise this kind of cloned component.

Or once you try to click on it, if a knowledge view already exists, then load this and it's associated components.