AKROGIS / Robo-Website

A robocoopy log processor and website for monitoring status
0 stars 3 forks source link

Change Log Date Checking in Log Processor #9

Closed regan-sarwas closed 3 years ago

regan-sarwas commented 3 years ago

Add additional change log date checking while processing logs 1) Log an error instead of accepting a change log date in the future 2) Log an error instead of ignoring a change log date earlier than previous change date 3) Log an error instead of doing a string compare if the value in the change log is not a date.

regan-sarwas commented 3 years ago

Regarding item 2, There will be lots of dates in the file earlier than the previous change date, and that is not an error. File scanning stops when we find a date earlier than the most recent change date (Change log is assumed to be in order with newest changes on top). We only scan the change log if the modification date is greater than the most recent change date. Therefore, it is an error if we do not find a valid date newer than the previous change date.

regan-sarwas commented 3 years ago

Added with commit 14f529e2175c90e83dc6ee34ddb1c7909d236787