search

AKSW / LSQ

Linked SPARQL Queries (LSQ): Framework for RDFizing triple store (web) logs and performing SPARQL query extraction, analysis and benchmarking in order to produce datasets of Linked SPARQL Queries
http://lsq.aksw.org
Apache License 2.0
25 stars 11 forks source link

debian package: change dependency to java8-runtime-headless #19

Closed lennartaustenfeld closed 3 years ago

lennartaustenfeld commented 3 years ago

Instead of depending on a specific java runtime package (openjdk-8-jre-headless) the debian package should depend on the java8-runtime-headless metapackage. This allows the use of other jdk packages such as adoptopenjdk. It also seems to be in line with the debian packaging guidelines found here: https://www.debian.org/doc/packaging-manuals/java-policy/ch02.html#policy-programs "Programs must depend on the needed runtime environment (default-jre or default-jre-headless if need a GUI or not, and java-runtime or java-runtime-headless as provided by alternative Java environments)." This also makes it possible to install the package on newer os versions (such as debian buster or ubuntu 20.04) which no longer ship openjdk-8-jre-headless.

It might also be possible to use a different dependency string (such as default-jre-headless (>= 2:1.8)), but java8-runtime-headless seems to be the cleanest solution.

Aklakan commented 3 years ago

Thanks for the contribution; however I merged the other PR which replaced depends with recommends as it seems more defensive and future proof.