search

AKSW / OntoWiki

Semantic data wiki as well as Linked Data publishing engine
https://ontowiki.net
204 stars 51 forks source link

Check Uri for Knowledge Base Creation #400

Closed shinobu closed 7 years ago

shinobu commented 7 years ago

This fix checks the URI for knowledge base creation for http://

This Pull Request does fix #399

shinobu commented 7 years ago

done in https://github.com/AKSW/Erfurt/pull/129 --- is the error message ok?

shinobu commented 7 years ago

now uses error codes to check if the exception gets catched or not

white-gecko commented 7 years ago

Do URNs (urn:…) and https:// URI still work?

shinobu commented 7 years ago

are urn:'s really valid RDF/Modelnames?

*edit this change will make them viable choices as well

white-gecko commented 7 years ago

What about ftp://… and tel:… I think there are more valid kinds of URIs resp. IRIs and afaik all of them are allowed for models.

https://tools.ietf.org/html/rfc3986 https://tools.ietf.org/html/rfc3987

https://en.wikipedia.org/wiki/Uniform_Resource_Identifier https://en.wikipedia.org/wiki/Internationalized_Resource_Identifier

shinobu commented 7 years ago

We are now using the PHP filter FILTER_VALIDATE_URL, We might need to add a test (the ModelController has no tests at all right now) to check if the filter works for all PHP versions though.

white-gecko commented 7 years ago

Could you add the test?

shinobu commented 7 years ago

Done @white-gecko This should be mergeable now