search

AKSW / cubevizjs

CubeViz.js is the successor of the CubeViz and provides statistical data exploration and visualization. Its completely written in JavaScript.
Other
16 stars 4 forks source link

Change link of cubevizjs.min.js to master branch version of the file on Github #10

Closed k00ni closed 8 years ago

k00ni commented 8 years ago

Path will be: https://github.com/AKSW/cubevizjs/tree/master/dist/cubevizjs.min.js

@GeorgesAlkhouri: He will merge and provide the final min.js file

GeorgesAlkhouri commented 8 years ago

Done.

Versioned cubeviz.min.js will be provided under:

https://raw.githubusercontent.com/AKSW/cubevizjs/master/dist/cubeviz.min.js

@simeonackermann, could you change the demo sites CubeViz integration to point to the above link?

Feel free to close issue when done.

simeonackermann commented 8 years ago

Thanks, applied to demo site and jsfiddles.

k00ni commented 8 years ago

Can this issue be closed?

GeorgesAlkhouri commented 8 years ago

@simeonackermann, CubeViz needs to be linked against this link:

https://raw.githubusercontent.com/AKSW/cubevizjs/master/dist/cubeviz.min.js

But currently points to the following:

http://cdn.rawgit.com/AKSW/cubevizjs/master/dist/cubeviz.min.js

And therefore can not display the current version of CubeViz.

simeonackermann commented 8 years ago

I thought these are the same versions (maybe the cdn is cached), except that the cdn sends the right content type (JS).

simeonackermann commented 8 years ago

Ok, it seems the cache is permanently.

simeonackermann commented 8 years ago

Alternatively it's recommended to use http://rawgit.com/AKSW/cubevizjs/master/dist/cubeviz.min.js , it's not cached but uses the right content-type and therefore reduces the load and performance.

simeonackermann commented 8 years ago

Done. Can be closed.