Closed Simaris closed 6 years ago
If I understand it correctly this pr addressed the issue, as pointed out in the readme:
Note: Since Jekyll 3.3.0 there is a special behavior of the jekyll serve command in a development environment. Jekyll overwrites the site.url variable with your host and port reference, as described in the Jekyll documentation. The behavior breaks the jekyll-rdf resource creation. If you want to use jekyll serve you have to set the environment variable JEKYLL_ENV=production.
It might not be a good idea to overwrite the behavior of jekyll for our plug-in in this case. Since there might be side effects, now or in the future.
I would suggest instead to output a warning in the case, that @site.config["url"] != Jekyll::JekyllRdf::Helper::RdfHelper::config["url"]
.
We should also support a new jeykll_rdf
config key baseiri
which would overwrite @site.config["url"]
and @site.config["baseurl"]
in any case.
path building should now work in developer mode too
Fix #102 properly.