search

AKSW / jekyll-rdf

📃 A Jekyll plugin to include RDF data in your static site or build a complete site for your RDF graph
http://aksw.org/Projects/JekyllRDF
Other
57 stars 10 forks source link

File path went from name to dir #154

Closed Simaris closed 6 years ago

Simaris commented 6 years ago

Fix #147 above issue brought a design flaw to my attention, that there since the beginning and causes us to endlessly redo resource.generate_file_name

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling fea768d4f8c1433bd4508ee16015db7b6ad22685 on Simaris:147/set_proper_page.name_attribute into 790ca72c00a7e97e20279a3f7bf0fffbcd0b11e6 on white-gecko:develop.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling fea768d4f8c1433bd4508ee16015db7b6ad22685 on Simaris:147/set_proper_page.name_attribute into 790ca72c00a7e97e20279a3f7bf0fffbcd0b11e6 on white-gecko:develop.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 734295c1fc195a2940af516e241bc2b6c812af7b on Simaris:147/set_proper_page.name_attribute into bd29794afac16869a9f4931c8baba63c87b6950b on white-gecko:develop.

white-gecko commented 6 years ago 
$ ls ../jekyll/_site/
C  README.md  Screenshot.png  d  e  feed.xml  html  rdf-data  rdfsites  t
Simaris commented 6 years ago

I added a fix for the problem above. Please check if it is fixed

white-gecko commented 6 years ago

Please check this and see how to make the fix of #155 still work. Also please fix the tests to also cover this behavior.

Simaris commented 6 years ago

made the fix but the index.html => .html bug keeps now coming up

also, I still need to test page.name