FAILING: Add failing test MWE for prefixes not available for posts

AKSW / jekyll-rdf

📃 A Jekyll plugin to include RDF data in your static site or build a complete site for your RDF graph

http://aksw.org/Projects/JekyllRDF

Other

57 stars 10 forks source link

FAILING: Add failing test MWE for prefixes not available for posts #257

Closed white-gecko closed 5 years ago

white-gecko commented 5 years ago

Fix #256

[x] Create a new branch for the fix
[x] fix it to work also for posts using a gem based theme
[x] check what is about documents

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling a897d580252898eaf67420a9d5100d870f026d0d on feature/noPrefixesInPost into a91a2f5f0d5baf04a0e46bfae3b0c795650699e8 on develop.

white-gecko commented 5 years ago

Why is the instance_template_mapping important? I've defined the layout for the post already in its front matter. Also is the path calculation really as stable as page.instance_variable_get(:@base)? E.g. if I execute jekyll from within a different directory?

Simaris commented 5 years ago

your restriction lets jekyll-rdf render a resource. This resource needs a template. The rendering of the post and the rendering of a resource are two different things. They just might get merged in the end.

white-gecko commented 5 years ago

Ok I understand this part. What do you think about the path?

Simaris commented 5 years ago

the path part should be stable, but we should test this by loading posts from a theme (if that is even possible). Then we know for certain.

white-gecko commented 5 years ago

I've tested it with the jod theme and it does not work. The system does not find the prefix file because it is looking for it in the local directory and not in the jekyll base path.

Simaris commented 5 years ago

turns out document hooks are always called for each kind of documents (page, posts). I don't think we should implement a prefix hook for all documents, since we can only be sure about specifics if the document is a page or post.