search

AKSW / jekyll-rdf

📃 A Jekyll plugin to include RDF data in your static site or build a complete site for your RDF graph
http://aksw.org/Projects/JekyllRDF
Other
57 stars 10 forks source link

replace umlauts in uri file names #71

Closed Simaris closed 7 years ago

Simaris commented 7 years ago

Fix #65

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 888037d8837adc06d6ac9326d2da179227628bdf on Simaris:parsing_umlauts_uris into e242d9754e9193d1b71332ee875ac712ea582307 on white-gecko:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 888037d8837adc06d6ac9326d2da179227628bdf on Simaris:parsing_umlauts_uris into e242d9754e9193d1b71332ee875ac712ea582307 on white-gecko:develop.

Simaris commented 7 years ago

that pullrequest is a workaround #65 it does not solve the problem but replaces äöüß to corresponding ascii combinations

white-gecko commented 7 years ago

But replacing the umlauts is not the intended behavior. Is this problem caused by some underlaying function?

Simaris commented 7 years ago

The problematic function is URI::split(iri). It throws an Exception which causes the resource to be rendered in /rdfsites/invalids/

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling df89fdf7ad390fc3da1a1be5068104bc874b3b34 on Simaris:parsing_umlauts_uris into e242d9754e9193d1b71332ee875ac712ea582307 on white-gecko:develop.

Simaris commented 7 years ago

I switched to another function that seems to work just fine with some adjustments to the code.

white-gecko commented 7 years ago

Cool, could you please squash the commits? then the pull request should be ready for merging.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b7ac5f7e3fddfdc49d525cf9f574abfdc5de8e1b on Simaris:parsing_umlauts_uris into 2048b2174248e5f0c175fb3f593e9d5049b467e4 on white-gecko:develop.