search

AKSW / shaclgen

python program to generate template shacl graphs
The Unlicense
23 stars 8 forks source link

Add support for closed shapes? #15

Open berquist opened 2 weeks ago

berquist commented 2 weeks ago

I'd like the ability to blanket add sh:closed true to all my node shapes. (I don't think it's possible to add any finer granularity here other than "on" or "off" at generation time.) Doing so will also require adding sh:property [ sh:path rdf:type ] or sh:ignoredProperties (rdf:type) which is reasonable considering closed shapes are already adding additional restrictions anyway.

Since I'd like this for a project I'm going to implement it, but would it be accepted for merging into the main project?

white-gecko commented 2 weeks ago

Yes, please go ahead and add an option for it. Please add tests and make the pull-request clear so that it is easy to review, this will increase the chances to be merged quickly.