ALBA-Synchrotron / sardana-adlink

Repository for the Sardana plugins related to AdLink
GNU General Public License v3.0
0 stars 1 forks source link

added required methods and some changes for python 3 compatability #2

Closed 13bscsaamjad closed 4 years ago

13bscsaamjad commented 4 years ago
13bscsaamjad commented 4 years ago

Thanks for the review. I have now removed StartOne and PreStartAll.

13bscsaamjad commented 4 years ago

@rhomspuron sorry, which one?

rhomspuron commented 4 years ago

Hi @13bscsaamjad,

Sorry I did not select the correct file. Could you revert the bump version commit? We use the bumpversion: https://pypi.org/project/bumpversion/, to change the version. It changes two files at the same time: setup.py and .bumpversion.cfg, and creates a tag for the version. We recommend to not change by hand the version, we will do it after to integrate the PR.

Thanks, Roberto