search

ALBA-Synchrotron / sardana-icepap

IcePAP plugins for Sardana
GNU General Public License v3.0
0 stars 2 forks source link

moved _configureMotor return to after the values updated #10

Closed AOVya closed 2 years ago

AOVya commented 2 years ago

There was an issue in BL16 where the user would change the offset of the motor and the following scan macro wouldn't execute correctly. This was caused because of an early return statement which prevented the update of the values from the motor in the controller. This is solved by moving the return statement to after the values update. Needs to be checked for side effects.

reszelaz commented 2 years ago

Good catch @AOVya and @srwohl !

Similar fix should be done on https://github.com/ALBA-Synchrotron/sardana-icepap/pull/7. Could one of you do it? You can push directly to that branch.

Merging and bumping version to 1.0.5.

reszelaz commented 2 years ago

Good catch @AOVya and @srwohl !

Similar fix should be done on https://github.com/ALBA-Synchrotron/sardana-icepap/pull/7.

Merging and bumping version to 1.0.5.