search

ALBA-Synchrotron / sardana-icepap

IcePAP plugins for Sardana
GNU General Public License v3.0
0 stars 2 forks source link

Off state when motor power is off #8

Open HEnquist opened 2 years ago

HEnquist commented 2 years ago

This changes the state of each axis to Off when the motor power is off.

This relates to this change in the sardana docs: https://gitlab.com/sardana-org/sardana/-/commit/69c0c7ffc2863dd2d9b76344df119186d02684c0

reszelaz commented 2 years ago

I would still not merge it. There is an issue in Sardana when one power on/off the motor - see my tests .

I also propose to return False in the PreStartOne() method when there is no power.

rhomspuron commented 2 years ago

@reszelaz if the motor is off, the current state is Alarm, should it return False on the PreStartOne anyway?

reszelaz commented 2 years ago

@reszelaz if the motor is off, the current state is Alarm, should it return False on the PreStartOne anyway?

The client is still able to request the move if the motor is in Alarm. Then the PreStartOne() returning False will prevent to actually sent the request to the hardware. DummyMotorController implements it like this.

aureocarneiro commented 1 year ago

Hi @reszelaz , @rhomspuron, I want to resurrect this PR, can you continue the review ?

rhomspuron commented 1 year ago

Hi @reszelaz,

In your test you reported that the Taurus widget does not work fine, is it solved?

Roberto

reszelaz commented 1 year ago

Hi @aureocarneiro , @ajoubertza, @rhomspuron

I just opened https://gitlab.com/sardana-org/sardana/-/issues/1809 in Sardana to try to unblock this MR: it would help if you comment there with your experince about other motion controllers.