search

ALBA-Synchrotron / sardana-tango

Repository for Sardana Tango plugins (TangoAttributeCtrls, etc)
GNU General Public License v3.0
0 stars 3 forks source link

fix for sardana 3.0.3 in TangoAttrCTCtrl.py and tests for pep8 #4

Closed jkotan closed 3 years ago

jkotan commented 3 years ago

Hi,

we have tested TangoAttrCTCtrl with sardana 3.0.3 and it turns out we get an error without a second parameter (values) of StartOne command. I've also add flake8 tests in travis for pep8 and apply necessary corrections.

jkotan commented 3 years ago

I've moved flake8 travis tests to the github workflow action (it looks like actions for the repository are disable).

reszelaz commented 3 years ago

Now I reviewed also the history of commits, and it looks like not related commits were included in the PR. They do not change the codebase, so not really problematic, but for the future please try to avoid them so it will be easier to review the history if necessary.

jkotan commented 3 years ago

Yes. Sorry, I've created the PR from my forked repo (removing staff we use only at DESY e.g. setup.py).

reszelaz commented 3 years ago

Having a setup.py would also help in this project:)