search

ALIENQuake / ProjectInfinity

Project Infinity - a mod manager for Baldur's Gate Enhanced Edition, Icewind Dale Enhanced Edition, Planescape Torment Enhanced Edition and Enhanced Edition Trilogy (EET).
https://forums.beamdog.com/discussion/74335/project-infinity-public-beta-for-all/p1
71 stars 7 forks source link

Sorting order file does not work for A#7ImprovedShamanicDance mod #14

Closed ckoegit closed 3 years ago

ckoegit commented 4 years ago

Check requirements: Windows10, 64 bit, current patchlevel

Upload logs from Logs folder Attached. Also attached is a screenshot which hopefully shows what the problem is. Logs.zip

Preliminary Remarks: When you check the logs you will see that I had to cancel an installation once after hitting "Start-Installation" instead of "Apply-Sorting Order", but I assume that is not a factor for the bug described below. However, the button layout might be a usability/ GUI design issue in general.

I selected "SoD" as game, I believe this is wrong and should be "BG:EE", but believe that is also unconnected to the bug.

Describe the bug The sort order from the file open in the screenshot is not applied to the A#7ImprovedShamanicDance mod components. They end up in the unsorted category. The sort order file works fine for everything else. At the moment I would assume that the hash mark "#" in the mod name breaks the file parsing.

Also, "Warning" appears to be misspelled as "Warring".

To Reproduce Get the mod and try a sort order file. The sort order file used is attached. MY_BGEE_sort_order.txt

Expected behavior Mod is correctly sorted in install order as specified in the sort order file.

Screenshots a7_project_infinity

ALIENQuake commented 4 years ago

@ckoegit Reported some time ago and fixed for 0.7.9 :)

BTW: You might want to use * instead of every single component number, please read the docs: https://github.com/ALIENQuake/ProjectInfinity/wiki/Sorting-Order-feature

ckoegit commented 4 years ago

Thank you. I will wait for 0.7.9 to become available then for my next try.

In this case the "*" wildcard would not work because that would include component 40 (Shaman-specific items for IWD:EE) as far as I understand the possible variants ? I will re-read the documentation.

I generated the sort order from a mostly up to date BWS-type InstallOrder.ini with just egrep/awk, so not much effort with it the way it is :-)

EDIT: OK, I see. Component 40 gets already disabled by the specification in the tp2. So, in this case I could use a wildcard if I were not too lazy.

ALIENQuake commented 4 years ago

In this case the "*" wildcard would not work because that would include component 40 (Shaman-specific items for IWD:EE) as far as I understand the possible variants ? I will re-read the documentation.

The Sorting Order feature doesn't add or include any mods/components to the installation sequence.

ckoegit commented 4 years ago

Yes, I vaguely remember now. There is some kind of (not very prominent) warning if the sort order does not match the component selection I think ? I first made the sort order file and then selected the components according to that. Having two unaligned lists, i.e. selection and sort order, feels somehow strange to me. Would it not be possible to select components according to the sort order file (perhaps only if it is explicit enough, e.g no wildcards or so ?). I will give the tool another try as soon as 0.7.9 is released, at the moment it does not install the mods I want.

ALIENQuake commented 4 years ago

@ckoegit Two lists are essentially a "correct install order of the mods" and "mods, which I want to install for the current game". Combining two into one convert it into a simplified version of 'weidu.log' with all its limitation.

I will give the tool another try as soon as 0.7.9 is released, at the moment it does not install the mods I want.

Which mods aren't installed?

ckoegit commented 4 years ago

Two lists are essentially a "correct install order of the mods" and "mods, which I want to install for the current game". Combining two into one convert it into a simplified version of 'weidu.log' with all its limitation.

I assume you write "limitation" because your design is to have a "universal" sort order file and then just select components on top ? If yes: can that sort order file be truly completely independent of the selected mods ? Probably that has been discussed to death already, so I accept that if it is the case.

But to me not being able to tell the program optionally "use the sort order to select components" feels strange and limiting as I wrote. The risk at least is divergences in selection and sort order. The current warning (if I remember correctly at all) is too easy to miss eventually.

Which mods aren't installed

Well, the one mentioned in the subject. I did not test it I admit, writing "it does not install the mods I want" is too strong wording then. But:

I cannot set its position in my sort order file obviously. With that I am not sure when it would be installed. Eventually randomly or at the start before all others or at the end after all others ? I do not know from the GUI and I have no way to check in advance. There is no obvious way to load a sort order file and then modify the loaded sort order (I could find). I could actually run the whole install (waiting several hours) but expect that I get a messed up install.

I am quite happy with my BWP install right now. So this is by no means important (or urgent). So please do not worry !

ALIENQuake commented 4 years ago

@ckoegit I will think about a more direct way to inform players regarding failed sorting.

There is no obvious way to load a sort order file and then modify the loaded sort order (I could find).

There is - simply cut and paste install sequence data after sorting. Then immediately click "Start-Installation" button.

Anyway, this is fixed by 0.7.9.