search

ALM-Rangers / Countdown-Widget-Extension

Counts down to a configurable moment in time.
https://marketplace.visualstudio.com/items?itemName=ms-devlabs.CountdownWidget&utm_roundup=github
Other
11 stars 16 forks source link

Using global CDNs make it unusable on offline on-prem TFS servers #1

Closed evakili closed 6 years ago

evakili commented 8 years ago

This project loads jquery from an online CDN, thus could not be used on servers that are not connected to the Internet.

michha commented 8 years ago

In countdown.html and countdownconfiguration.html jquery is loaded from code.jquery.com in version 1.11.1 but there is also a local jquery.js in scripts/lib but thats version 3.1.0 . So maybe everything to solve the issue is already in the extension. If I would know how to test code changes for this extension, I could try to make a pull request.

WouterDeKort commented 8 years ago

Hi @michha, you can test the extension by compiling the code locally and then using the NPM scripts in the package.json file to package the extension. You can then install this extension locally in your own account with your own publisher and test it. This is documented at https://www.visualstudio.com/en-us/docs/integrate/extensions/publish/overview.

A pull request would be very welcome!

WouterDeKort commented 7 years ago

@evakili, I've been working on updating the Countdown Widget and I've also fixed this issue. Can you please try the newest version and see if it fixes your issue and now works on your disconnected servers?

markvandenberg commented 7 years ago

@WouterDeKort, Where can I find the latest resolving this issue? I have the same problem and like to test it.

evakili commented 7 years ago

@WouterDeKort Did you ask me to build it from Github repo? There are no updates on VS marketplace.

wpschaub commented 7 years ago

@markvandenberg @evakili we're busy validating the latest version and will publish to marketplace shortly.