search

ALM-Rangers / Visualize-Team-Project-Health-Widgets

Enable users to visualise the overall health of builds, releases, bugs, and pull requests on their dashboard, delivering a visual cue similar to the Codify Build Light. Marketplace: https://marketplace.visualstudio.com/items?itemName=ms-devlabs.TeamProjectHealth
Other
20 stars 17 forks source link

Display builds not started in another color #14

Closed pmiossec closed 6 years ago

pmiossec commented 6 years ago

Changes proposed in this pull request:

Display builds not started in another color (grayed blue) to be able to distinguish build running and build not started and waiting to build...

@ALM-Rangers/Visualize-Team-Project-Health-Widgets

WouterDeKort commented 6 years ago

Thank you for your pull request! I'll verify the changes and deploy a new version to the marketplace.

WouterDeKort commented 6 years ago

Hi @pmiossec,

I've tested the changes and everything seems OK. One thing I was wondering about is your color choice. For me, there is little difference between:

@not-started: #7489c9;
@building: royalblue;

Are you sure you want this color combination? I was thinking of something a bit more obvious for not-started. Purple looks pretty good in my opinion.

Agreed?

Wouter

pmiossec commented 6 years ago

For the color, I choose something similar to building to let know that it "will be" built.

But I agree with you that we should easily see the difference between the two.

I'm OK for the color you want if you think that the 2 colors are not enough distinguishable.

Purple is OK for me if you think it's better.

WouterDeKort commented 6 years ago

Great!

Only issue I'm running into at the moment is that the screenshots that we show on the Marketplace page are not loading. I'm not sure why this is happening and I don't think it's related to your changes.

Once that's fixed I'll deploy a new version with the new purple state.

Thanks! Wouter

pmiossec commented 6 years ago

Thanks for the merge and publish.

pmiossec commented 6 years ago

Once that's fixed I'll deploy a new version with the new purple state.

Any update on that?

pmiossec commented 6 years ago

When do you think you will be able to release a new version?

jakobehn commented 6 years ago

Just added a PR that should fix the incorrect screenshots link in marketplace.

@WouterDeKort can you approve and test?

pmiossec commented 5 years ago

Anything new?

WouterDeKort commented 5 years ago

@pmiossec no :( Unfortunately we're having some problems with the ALM Ranger publisher. We've lost access to our current publisher so we can't push any updates. Microsoft is investigating if we should move to another publisher and deprecate the current one or if there is another solution.

Sorry that this is taking so long. It has nothing to do with our extension but with some Ranger infra problems :(

pmiossec commented 5 years ago

No problem, I understand. That's just that I don't want that my contribution was useless so I want to see it deployed one day 😉 If things are moving, I'm happy 😄

pmiossec commented 5 years ago

Hi @WouterDeKort , do you think this PR will be released one day?