search

ALM-Rangers / Visualize-Team-Project-Health-Widgets

Enable users to visualise the overall health of builds, releases, bugs, and pull requests on their dashboard, delivering a visual cue similar to the Codify Build Light. Marketplace: https://marketplace.visualstudio.com/items?itemName=ms-devlabs.TeamProjectHealth
Other
20 stars 17 forks source link

Builds with similar names show up in Build Health Overview #5

Closed Sjors-Boom closed 6 years ago

Sjors-Boom commented 6 years ago

Build definitions with similar names are included in results.

Steps to reproduce

  1. Create builds with similar names: Foo.Bar and Foo.Bar.Gated

  2. Configure Build Health Overview only for build Foo.Bar.Gated

  3. Run both builds

Result

The overview shows results from both build definitions.

Investigation This line is the culprit: definitions = definitions.filter(def => customSettings.selectedDefinitions.indexOf(def.name) != -1);

Foo.Bar is present within string Foo.Bar.Build Thus not filtered from the original set of build definitions

proposed solutions

  1. split customSettings.selectedDefinitions and check for full match
  2. when selecting builds store the build id's in customSettings.selectedDefinitions (note: when a build is regenerated and gets a new id it won't be in the results)
WouterDeKort commented 6 years ago

Hi @Sjors-Boom,

thanks for bringing this up and even working on a fix! I've accepted your pull request and I'll make sure it goes live ASAP.

Thanks for helping us out!

Wouter

jaalvarezvi commented 5 years ago

Dear all,

Thank you very much for the work and support.

We are facing the same issue. For what I see, this should be fixed! Could you please lend us a hand with this problem? What is the current status of this issue?

Thank you a lot!

TheNitek commented 4 years ago

This fix has not yet been released, has it? Any plans to do this soon?