search

ALPHAVIO / Mirage-UI

Mirage-UI is a set of easily accessible, reusable, and composable design components and animations that make it super easy to improve the user experience of your websites and applications.
MIT License
24 stars 41 forks source link

Added Auto scrolling background component #181

Closed Anupam-Panwar closed 3 years ago

Anupam-Panwar commented 3 years ago

What is the change?

Added a directory named Auto-Scrolling-Background in HTML+CSS+JS/Background

Related issue?

closes: #164

How was it tested?

Component was thoroughly tested in Chrome Browser

Checklist:

GIF you created:

auto scroll background

ghost commented 3 years ago

Hey there! :wave: This repository uses the Prettier code style.

You forgot to format these files in your pull request:

The Prettier installation guide is a good place to get started with formatting your code properly. Thanks!

:heart:

Your friendly Prettifier bot.

Pranav016 commented 3 years ago

What is the change?

Added a directory named Auto-Scrolling-Background in HTML+CSS+JS/Background

Related issue?

closes: #164

How was it tested?

Component was thoroughly tested in Chrome Browser

Checklist:

  • [x] Have you followed the Contribution Guidelines while contributing.
  • [x] Have you checked there aren't other open Pull Requests for the same update/change?
  • [x] Have you made corresponding changes to the documentation?
  • [x] Have you tested the code before submission?
  • [x] Did you lint and format your code before making the Pull Request?
  • [x] Have you made the GIF for the component you added?

GIF you created:

auto scroll background

I think people might not be able to tell any scrolling in this gif. Maybe change some background colors of sections

Anupam-Panwar commented 3 years ago

@Pranav016 I have incorporated the suggested changes

Pranav016 commented 3 years ago

@Anupam-Panwar Everything looks good 👍 But I was thinking that there isn't any need of using such a long URL for setting a background image. You can very easily set any local image from the assets folder (after adding the asset folder in the HTML+CSS+JS/Background/Auto-Scrolling-Background and then using images from there. This might also make it difficult from a user perspective, in the sense that they might not be able to reuse it that easily as they would have been by replacing the URL from the local folder.

Even then, let us wait for the views from @Pranav016.

I agree with this review @Anupam-Panwar can you use another image with a shorter link? That would do the job 👍