ALPHAVIO / WordNook

Dynamically updating blogging website to upload articles and blog posts on various topics, developed using ejs template engine and node js in the backend.
https://word-nook.herokuapp.com/
MIT License
81 stars 176 forks source link

Add constraints for email, username and password during sign-up #163

Closed Pranav016 closed 3 years ago

Pranav016 commented 3 years ago

Feature request

Add constraints for email, username and password during sign-up

Describe how this feature will be useful to our readers.

Improves security and helps maintain consistency.

ranjal007 commented 3 years ago

@Pranav016 Can I work on this issue?

Pranav016 commented 3 years ago

@Pranav016 Can I work on this issue?

Yes sure, let me know under which program will be working?

ranjal007 commented 3 years ago

@Pranav016 Gssoc

ranjal007 commented 3 years ago

@Pranav016 Can you please elaborate the documentation of setting up the environment. I am not getting which url you are asking to change in app.js

Abhijay007 commented 3 years ago

@ranjal007 change this part in app.js:

const URL = process.env.URL;

to this:

const URL = 'mongodb://localhost:27017/blogDB';

Pranav016 commented 3 years ago

@Pranav016 Gssoc

I don't thing development phase for GSSoC starts till 1st March. You can work on the issue if you want, but you might not get any points for that.

Pranav016 commented 3 years ago

@ranjal007 change this part in app.js:

const URL = process.env.URL;

to this:

const URL = 'mongodb://localhost:27017/blogDB';

Thanks for the assistance @Abhijay007 👍

Pranav016 commented 3 years ago

@ranjal007 are you still working on this?

mcmonojit commented 3 years ago

@Pranav016 , if this issue is open then I would like to work on it.

Pranav016 commented 3 years ago

@Pranav016 , if this issue is open then I would like to work on it.

JWoC is over, let me know if you still want to work independently..

sukhpreet-singh1 commented 3 years ago

@Pranav016 if this issue is open ,can you please assign me this issue?

Pranav016 commented 3 years ago

@Pranav016 if this issue is open ,can you please assign me this issue?

Under which program do you want to work? :)

sukhpreet-singh1 commented 3 years ago

@Pranav016 i am a participant in Girlscript summer of code (GSSOC)

Pranav016 commented 3 years ago

@Pranav016 i am a participant in Girlscript summer of code (GSSOC)

GSSoC hasn't started yet.. Do you still want to work? Points won't be given.

luckykumarirai commented 3 years ago

@Pranav016 I would like to contribute.

chehak123 commented 3 years ago

Hi, I want to work on it as a participant in GSSOC'21, can you please assign this issue to me?

abhinav5481 commented 3 years ago

Hello I would like to work on this issue as part of GSSOC21. Could you please assign it to me?

Esha-Sherring commented 3 years ago

Hello I would like to work on this issue as part of GSSOC21. Could you please assign it to me?

nikhilgupta2001 commented 3 years ago

As a participant of GSSOC'21 ,I would like to contribute to it. can u please assign it to me?

SARVESHKHANDELWAL commented 3 years ago

Hello, I would like to contribute to this issue so, can you please assign me?

hrushikesh-git commented 3 years ago

Hey @Pranav016 I love the idea and essence of the blogging site please assign this issue to me -GSSOC'21

AnanyaNegi commented 3 years ago

Glad to see your enthusiasm @hrushikesh-git @SARVESHKHANDELWAL @Esha-Sherring .This issue has already been assigned to someone else. You may take a look at some other issues.

abhinav5481 commented 3 years ago

Hi, I had created the PR. It was working as expected. May I know why I got unassigned to it?

abhinav5481 commented 3 years ago

Regarding the small change in the URL variable, I think it's a small change, and I have completed it now.

abhinav5481 commented 3 years ago

Please reassign it to me, otherwise, all my efforts would go into the vain

Pranav016 commented 3 years ago

Please reassign it to me, otherwise, all my efforts would go into the vain

I understand, but why wasn't there any response for 2-3 days on the previous PR

abhinav5481 commented 3 years ago

Hi, I think there is a little bit of misunderstanding. After creating the PR you asked me to change the base branch and I immediately changed the base branch to develop. Then yesterday only you asked me to update the URL to old (process.env.url), I completed that today ( but till that time it got unassigned). These were the changes that you asked me to do:

  1. image I changed that immediately: image

  2. Then yesterday you asked me to edit URL image

Please let me know, which request I didn't respond to for 2-3 days.

abhinav5481 commented 3 years ago

I have created another PR 13 minutes ago. That is still open. Should I now create another PR?