search

ALPSCore / CT-HYB

ALPS Hybridization Expansion Matrix Code
GNU General Public License v2.0
16 stars 13 forks source link

fix reading of string type param #17

Closed dombrno closed 6 years ago

dombrno commented 6 years ago

fixes #16

The change in main.cpp is not necessary with respect to any bug I have encountered, but I thought it could not hurt. Please feel free to reject if inappropriate.

shinaoka commented 6 years ago

Thank you for the contribution and comments! It seems that the use of as() and static_cast looks correct. Dominique, could you resubmit changes?

BTW, I need to fix Travis CI...

dombrno commented 6 years ago

Dear Hiroshi, Yes, it will be my pleasure to resubmit the changes, some time today. I was wondering if I needed to fix anything on my side for the Travis problems, but it looks like not? Dominique

dombrno commented 6 years ago

I think the pull request is ready for review now. Thanks!

shinaoka commented 6 years ago

Thank you for the update.

This is just because I have not had time to configure Travis properly... I will marge the changes.

dombrno commented 6 years ago

I see, clang and its surprises :)

shinaoka commented 6 years ago

Oh, it is nice to have Travis CI...