Missing plot scripts - Githubissues

ALSETLab / Modelica-Drone-3D-FMI

DroneLibrary: Multi-Domain Drone Modeling in Modelica with 3D visualization and FMU export configuration

http://alsetlab.com

BSD 3-Clause "New" or "Revised" License

47 stars 24 forks source link

Missing plot scripts #37

Closed dietmarw closed 1 year ago

dietmarw commented 1 year ago

The library contains several commands that are pointing to plot scripts that are missing.

mpodlaski commented 1 year ago

Added scripts back into library in 8e6c491f640f46318c6b20d377b5a13aba953f52

dietmarw commented 1 year ago

Unfortunately, the scripts were placed on the top level of the repo. Unreachable for the Modelica tools since outside the package. The proper place to store those non-modelica files is under Resources/Scripts/ and also point to them using modelica:// URIs. This was done in 924a4670807b90419cf69af692cf7c124140d626

Mind the script drone_simulation_setup.mos is only mentioned in the README and not part of any command. And the script plotOutput.mos is not mentioned anywhere and not used anywhere. So what is the purpose of this?

dietmarw commented 1 year ago

There is still one script missing: animate_gyroscope.mos

Can you add this in the correct location and also link correctly (see above)?

mpodlaski commented 1 year ago

ok thank you for moving the scripts!
plotOutputs.mos generates a standardized plot of the XYZ location of the drone when running the test cases, it needs to be added to the readme when I update it.
I removed the gyroscope package. It was also test files copied from another library, which is why we didn't have the .mos file in the place. The models are not used anywhere else in the library nor add any value to the library as it is now, so they can be removed. (done in 5c6a5cbcc63b1dff0279dbfa475be7ba037794c6 )