search

ALSETLab / Modelica-Drone-3D-FMI

DroneLibrary: Multi-Domain Drone Modeling in Modelica with 3D visualization and FMU export configuration
http://alsetlab.com
BSD 3-Clause "New" or "Revised" License
47 stars 24 forks source link

Rename package to DroneLibrary #43

Closed dietmarw closed 1 year ago

dietmarw commented 1 year ago

The name "DroneSimulation" is not quite optimal. I think calling it "DroneLibrary" or maybe just "DroneLib" might be much more suitable. What do you think?

mpodlaski commented 1 year ago

That works with me!

dietmarw commented 1 year ago

DroneLib it is then.

mpodlaski commented 1 year ago

I renamed it DroneLibrary, let me know if it works on your end before I delete DroneSimulation

dietmarw commented 1 year ago

The name is OK by me but I need to revert your change since the way you did it the history is lost. Git is aware if there are renames but simply adding a duplicate that duplicate will have no history whatsoever.

dietmarw commented 1 year ago

That change will take some more time since I'm travelling during the next week. Not sure if I will be able to push then.

mpodlaski commented 1 year ago

The name is OK by me but I need to revert your change since the way you did it the history is lost. Git is aware if there are renames but simply adding a duplicate that duplicate will have no history whatsoever.

ok, in Dymola I am changing it through renaming it and then it forces me to save a new directory. Does it need to be renamed manually?

dietmarw commented 1 year ago

Dymola does only half the job. The trick is to then also remove the old directory before creating a commit so that git recognises the rename. Anyway, I managed to fix this now but had to do a "force push". This means you can not simply pull the updates now but have to do a:

git fetch --all
git reset --hard origin/master

replace "origin" with the name of what you called your ALSETLab remote (e.g., in my case I called it "ALSETLab" instead of "origin")

dietmarw commented 1 year ago

Done in 1689681685bfaebfcf7085ec8e8e33f35199c49c