search

ALSETLab / RaPId

RaPId (a recursive acronym for "Rapid Parameter Identification") utilizes different optimization and simulation technologies to provide a framework for model validation and calibration of any kind of dynamical systems, but specifically catered to power systems.
GNU Lesser General Public License v3.0
40 stars 12 forks source link

Remove Dependency on Image Processing Library #43

Closed lvanfretti closed 8 years ago

lvanfretti commented 8 years ago

When we implemented the first version of RaPId, I wanted to display the logo. At that time (and still now) the only way that I knew how to do it was through some functions of the Image Processing library.

I think we can replace with the following function: http://se.mathworks.com/help/matlab/ref/imagesc.html

Otherwise, I guess there is not much point in keeping the image...

janlav commented 8 years ago

@lvanfretti you are correct that we don't need the image processing library - at present we are using imshow()which (from my understanding) actually is not part of the Image Processing lib. I think previous developers either used some other function or were deceived by the help text (the second part Examples use imref2d() of the Image Processing Toolbox but the first doesn't).

If no one disagrees I suggest that we just remove the Image Processing Toolbox from the dependencies list.

tinrabuzin commented 8 years ago

@janlav This dependancy list used to be created by the setup script. So, I guess there is another piece of code that uses Image Processing Toolbox if it appears in the list of dependancies generated by the script.

janlav commented 8 years ago

@tinrabuzin @lvanfretti turns out you guys was right, so I replaced imshow() with image() and imread() instead. Using (an improved) dependency check I can confirm that this eliminated the need for Image Processing Toolbox.

PR coming soon.