search

ALSchwalm / transient

A wrapper for QEMU allowing the creation of virtual machines with shared folder, ssh, and disk creation support.
MIT License
104 stars 17 forks source link

Suppressed a minor set of warnings when using --copy-in-before #155

Closed JeffreyMitchellSL closed 2 years ago

JeffreyMitchellSL commented 2 years ago

Judging by the redirect to /dev/null, these errors were intended to be suppressed anyway, but stderr never got redirected. This caused the following warnings when the VM I'm using runs with --copy-in-before:

mount: /mnt: operation failed: Invalid argument.
umount: /mnt: not mounted.
mount: /mnt: unknown filesystem type 'LVM2_member'.
umount: /mnt: not mounted.

Adding -v indicated that Transient was cycling through swap and LVM2_member partitions first while searching for /etc/fstab, for which the failures had no effect on successfully running the VM.

JeffreyMitchellSL commented 2 years ago

@ALSchwalm For whatever reason, Github failed the tests for my second push. My third is identical but with a slightly different commit message to kickstart another pipeline, which now passes.

ALSchwalm commented 2 years ago

Yep, I don't think I've ever been able to get CI working for this consistently. The non accelerated QEMU in the github actions sometimes seems very slow, I assume depending on what else is running on the same host.

Anyway, this LGTM. Merging and cutting a 0.25