ALXRSS / WebRTC-Conf

0 stars 5 forks source link

Geolocalisation #34

Closed Desiderius77 closed 9 years ago

Desiderius77 commented 9 years ago

On the demo page hosted at http://visio.gexsoft.com , I was surprised to see that when I click on the Geoloc button, a map appears immediatly and I do not see a popup windows asking me wheter I want to be localized or not ?

People explicitly asked me yesterday if the product works normally if the user does not want to be localized.

micbuffa commented 9 years ago

I told you, it's a protocol problem. For me : chat + geoloc + p2p file transfert does not work, and I've got this on the console : http://i.imgur.com/yeedSOl.jpg

j-mulenet commented 9 years ago

We think that it's a problem with the adress assigned in the socket client, Client try to connect with socket.io but it can't because the adress was assigned to "localhost". We will fix that soon.

micbuffa commented 9 years ago

Yes, it's a good practice not to do var socket = io.connect('http://'+location.hostname + ':3000');

But instead io.connect(); // Means -> connect to the server that served the page !

polskataga commented 9 years ago

Yes, the product works normally if the user does not want to be localized. The user has the choice.

micbuffa commented 9 years ago

I updated the version that is online with yersterday's last version of one-to-many-current.....

I have a strange error in the console relative to socket.io-stream, "undefined symbol", when I click to see the error in the js file, the js file only contains "welcome to socket.io-stream". I added socket.io streams to the package.json file + did a npm install. maybe I broke something ?

Anyway, the app at visio.gexsoft.com seems to work pretty well, except the geolocation thats eems to be broken. When I started the app as a second participant, it blocked for 30s "wating for ajax.googleapis.com" in the browser's status zone, then the room I created with the first participant appeared, it took 30s to see the room on screen. Is it normal ?

micbuffa commented 9 years ago

Errors I've got :

micbuffa commented 9 years ago

Also, what is the second icon on the top left, the finger with a line ? It does nothing for me ? Do you want me to put online other versions ? Many to many ? etc ?

polskataga commented 9 years ago

Hi, the app at visio.gexsoft.com seems to work for us too. We cannot try to test the geolocation now because of the restriction we have at work, however we tested this point yesterday with success. What is exactly the problem you have with the geolocalisation ?

Futhermore, When we want to join a room as a second participant, it takes only a few seconds for the room created to appear (after the two pop-up referring respectively to the geolocalisation and the webcam). Do you think it is a question of speed internet connection ?

polskataga commented 9 years ago

Otherwise, the second icon on the left you are talking about allows you to "drag and drop" the videos of the different participants. When you click on this button, all the videos displayed become draggable.

Yes why not, you can try to put online many2many-current-version.

Desiderius77 commented 9 years ago

The new version at http://visio.gexsoft.com seems to work well !

Geoloc is working and is fast ! Chat also work ! and the list of participants is correct

@polskataga I have tried the seconnd icon to drag vidéos : wonderful ! But how can I get back ? That is : I do not want to drag the videos anymore ! I have to try to click again on the icon but without successs

Desiderius77 commented 9 years ago

For Geolocalisation I use the Mozilla Location Service on my laptop

polskataga commented 9 years ago

Indeed @Desiderius77, we have to work on it. There is no way to disable the Drag'n'drop for the moment. Maybe we would disable the function on a second click on the same button or another button ...

j-mulenet commented 9 years ago

@micbuffa For the problem with socket.io.stream, it's a error that we forget to delete, but it does not prevent the functioning of send file.

For send file one to one, we need used the socket for send file, because we have problems to make the correspondence between users in peer to peer and user socket.

Concernly the problem of maps, the position was send when the user click on the button of geolocalisation. There are a bug with google chrome, it send onetime the position at the first connection to server and at other connection it don't ask if the user want to be locate. User must delete anytime the choice after connection. We check yet for fix this problem. For Firefox it's ok because it ask always if the user want to be locate or not every time when it connects.

Desiderius77 commented 9 years ago

@polskataga Removing the "draggable= true" attribute on the video tag is not sufficent ?

An error in the HTML5 spec or in the Firefox implementation ?

polskataga commented 9 years ago

Yes @Desiderius77, it can be done removing the "draggable= true" attribute on the video tag but we did not know if we had to create a second eventListener on the same event "click" on the same button OR create another button only to disable the function.

Maybe, we have to create a boolean to check if the videos have the attribute "draggable= true".

Desiderius77 commented 9 years ago

Yes you can check if the video has the attribute "draggable= true" and you change the icon according to the status : one icon for dragging enable and anotherv one for dragging disabled

micbuffa commented 9 years ago

Ok, geoloc is not working for me on Google Chrome while all my geoloc examples on jsbin.com works well. Here is a picture of what I see when I try on my machine with two tabs and two participants :+1:

micbuffa commented 9 years ago

Same error with firefox :+1:

micbuffa commented 9 years ago

As you can see the map does not show a correct position. And it's not a network problem, as I told you all my examples of geoloc work well, same machine, same browser, same wifi.

Desiderius77 commented 9 years ago

@micbuffa Strange ! I have just relaunched the page to check : Geoloc is working fine and get the right position ( Firefox ) ; I will check with Chromium on Linux

Desiderius77 commented 9 years ago

Same with Chromium : position acquired in 5 seconds and right !

micbuffa commented 9 years ago

I'm on a Mac. Also, a suggestion, I don't know if you've done it or if you have time to do it: Click on the name of a participant and center the map on him. This is really cool.

Desiderius77 commented 9 years ago

No I will try !

here is the snapshot of my firefox window webrct

micbuffa commented 9 years ago

Hmmm.... you connected only one user, ot there must be at least twice ? Did you try on two tabs same machine ?

Desiderius77 commented 9 years ago

I only connecteed myself in the room ?

I will try with two tabs

micbuffa commented 9 years ago

It does not work for me, I tried several times, on ff, opera, chrome... ALso, on your screenshot, it would be good to be able to see in a tooltip the name of the person, when we put the mouse on the small blue man's icon... (maybe you've done that, but as geoloc does not work for me...)

micbuffa commented 9 years ago

And I've got also lots of warning/errors in the console in socket.io, in jquery etc I will take screenshots

micbuffa commented 9 years ago

Desiderius77 commented 9 years ago

Sorry for you Michel !

I have tried with 2 tabs and everything works well ( Firefox Linux ) ; Effectively when I click on the blue icon on the map , I get my pesudo !

micbuffa commented 9 years ago

Ok, I think the problem is somewhere else... give a look at the errors in my console, check if you've got the same. I was alone before even entering a room when I took the screenshot. After authorizing geoloc + entering nickname.

Did you see my comment about centering map when cliking on a member's name. This is a nice feature to implement if you have time.

j-mulenet commented 9 years ago

The problem that micbuffa meeting with maps was a random problem we know with some people, we will fix it soon. We will based on example of jsbin. We will add the functionnality for centering map

micbuffa commented 9 years ago

Ok, no stress, I'm in a boring meeting so I work a little testing your project :-)

j-mulenet commented 9 years ago

I send a pull request that fix the problem of send of geoposition. It's resolved.