search

ALiVEOS / ALiVE.OS

ALiVE Open Source GPL v2
http://alivemod.com/
Other
157 stars 80 forks source link

Add option to disallow diary entries when creating a SPOTREP #579

Closed xetra11 closed 5 years ago

xetra11 commented 5 years ago

Description

When creating a SPOTREP it will be automatically added to the diary. When removing the SPOTREP it will not disappear from the diary. Since diary entries cannot be removed by default it should at least be possible to have a checkbox in the SPOTREP to disallow diary entries.

Steps to Reproduce

  1. Create a SPOTREP
  2. Remove it
  3. Check diary and be sad

Expected behavior: When creating a SPOTREP I want to have the option to allow/disallow a diary entry out of it.

Actual behavior: There will always be a diary entry added when creating a SPOTREP

DarrellJMartin commented 5 years ago

Commit: https://github.com/ALiVEOS/ALiVE.OS/commit/9baec23e2d6152a0ecce7e8e83aca8c5bcbe65cc

spotrep

xetra11 commented 5 years ago

Thanks a heap buddy! Will make the integration with ALiVE one step more beautiful

Will QA in a few and close issue if its ok, aye?

DarrellJMartin commented 5 years ago

Yeah sure. I was going to put the boolean option in the marker's ctrl panel but thought it better to put it in the C2istar module params.