ALiVEOS / ALiVE.OS

ALiVE Open Source GPL v2
http://alivemod.com/
Other
160 stars 80 forks source link

Broken OPCOM Selection list in Intel and Operations when using multiple AI commanders on one side (different factions) #776

Closed CrashDome closed 1 year ago

CrashDome commented 2 years ago

Prerequisites

Description

When using multiple AI Commanders on one side, C2ISTAR displays multiple opcoms in selection list

e.g. Blufor Commander Blufor Commander Blufor Commander

Yet, selecting any one only shows data for the first OPCOM placed of that side

Steps to Reproduce

  1. Place Alive required, multiple AI Commanders for one side (using different factions) and an associated Mil placement for each one
  2. Launch game session, assuming setup for player to view Operations and Intel
  3. Selecting any OPCOM shows only the first OPCOM placed for that side in both Intel and Operations modules

I am actually submitting this because I've already traced the problem and fixed it in code. I intend to do a pull request and submit changes now that I've tested it and streamlined some things.

I also, since I don't like the idea of multiple "Blufor Commanders" in a list, decided to add a feature to the OPCOM module to customize a display name so Mission makers can actually name the individual AI Commanders whatever they'd like e.g:

Australian Forces USSOCOM 1st Infantry Battalion III Corps etc..

you probably get the idea

It's a textbox added to the AI Commander module called "Custom Name" and is used in the OPCOM Selection Lists in the Player UI

I guess this is a fix + feature enhancement