search

ALive-research / Slicer-Liver

3D Slicer extension for liver analysis and therapy planning
Other
15 stars 9 forks source link

Warning at installation #179

Open rahulpk opened 1 year ago

rahulpk commented 1 year ago

Description of the bug A warning appears when installing that Markups is needed for the module, but it could not be found.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Install Extensions'
  2. Install 'SliverLiver'
  3. See error
RafaelPalomar commented 1 year ago

Thanks for the feedback. We will look into this.

The error is related to the module Markups not being found. The module is part of the core Slicer application, so probably ther is no need to specify it as a requirement. @lassoan, do you have any insight on this? Should we remove the Markups module as dependency for SlicerLiver?

lassoan commented 1 year ago

If your module uses another then your module must return the name of that other module among dependencies of that module (in dependencies() method). These module dependencies are used for determining order for initializing the modules, i.e., to ensure that by the time your module looks for Markups module, the Markups module is already initialized, Markups logic is instantiated, etc..