search

ALive-research / Slicer-Liver

3D Slicer extension for liver analysis and therapy planning
Other
15 stars 9 forks source link

Module LiverSegments - designed as both Scriptable&Loadable module - needs refactoring #201

Open gatangen opened 1 year ago

gatangen commented 1 year ago

Describe the bug The design of module LiverSegments has both Python and C++ code and is initialised as a Scriptable module. It has logic code both in python and C++ which is confusion when using the module and when unit testing.

To Reproduce Only relevant to code design.

Expected behavior The module should be refactored to have a clear logic API in C++ and be initialised as a Loadable module.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

RafaelPalomar commented 1 year ago

The more we can translate to C++ the better (in general terms, this is what I think). We should discuss about the possibility to have Liver as a metamodule and an arena to introduce experimental changes and port these changes to C++ loadable modules.

RafaelPalomar commented 1 year ago

Decided on 20/03/2023 that the liver segments module should go on C++