search

AM1CODES / Poke-Dex

This is a small webpage that allows user to add their favourite Pokémons! This project aims to help people in creating their first pull requests and participating in Hacktoberfest 2021
https://am1codes.github.io/Poke-Dex/
MIT License
143 stars 381 forks source link

Fixing the Mobile View of the Website[Responsive] #268

Closed AM1CODES closed 4 years ago

AM1CODES commented 4 years ago

Screenshot_2020-10-09-08-56-22-687_com android chrome The Mobile view of the website is broken, need someone to fix it asap. Thank you.

FireLemons commented 4 years ago

can I have this assigned?

AM1CODES commented 4 years ago

can I have this assigned?

Yes its assigned to you. You can start working on it.

AM1CODES commented 4 years ago

Thank you for contributing! The website is responsive now. Just one thing, the up arrow at the bottom of the page is a little misalligned, so if you can bring it to center again, it would be great and just the like - "Show us your favourite pokemons" could be brought a little bit up in the mobile version so that the down arrow can fit in better. Thank you.

FireLemons commented 4 years ago

wait what happened wasn't there a comment about the header text still being misaligned vertically?

FireLemons commented 4 years ago

can you send a screenshot of what you just described?

FireLemons commented 4 years ago

did you clear the cache? I'm gonna try pulling it up on my laptop to see if anything is different

AM1CODES commented 4 years ago

Yes yes that part is cleared, it was an error on my part. Just the above mentioned issue is remaining rn.

AM1CODES commented 4 years ago

Screenshot_2020-10-10-09-00-58-348_com android chrome Screenshot_2020-10-10-09-00-51-365_com android chrome i was talking about these two things, if the down button could be shifted a little up.

FireLemons commented 4 years ago

ahh I see. I can re create the bug on chrome. It should be fixable

FireLemons commented 4 years ago

@AM1CODES could you please mark that merged pull request as hacktoberfest-accepted so it counts towards the 4/4 goal?

AM1CODES commented 4 years ago

ahh I see. I can re create the bug on chrome. It should be fixable

Okay. Try and work on it and see what changes you can make to it. Thank you.

AM1CODES commented 4 years ago

Yes i will label it as well

srishtij2000 commented 4 years ago

Can I work on this issue?

FireLemons commented 4 years ago

@srishtij2000 I want to share a little thing I noticed when first examining the issue: The width of the header would change after the page finished loading some element which takes several seconds but not longer than a minute.

srishtij2000 commented 4 years ago

So are you going to assign this issue or should I just submit the PR?

FireLemons commented 4 years ago

yeah just submit a pr

srishtij2000 commented 4 years ago

Okay okay

srishtij2000 commented 4 years ago

I have issued a PR so kindly review it

AM1CODES commented 4 years ago

This issue has been solved. Thank you for contributing @srishtij2000 @FireLemons