AM2R-Community-Developers / AM2R-Community-Updates

Source code for AM2R 1.5.2+, free of copyrighted assets and trademarks.
https://www.reddit.com/r/AM2R/
Other
139 stars 27 forks source link

Varia suit glow doesn't appear during cutscene #118

Open Miepee opened 2 years ago

Miepee commented 2 years ago

Describe the bug During the "get varia suit" cutscene, Sarah is supposed to have a glow around her. This got borked during the reconsuction I believe.

To Reproduce Obtain the varia suit

Expected behavior During the cutscene, Sarah should have a white glow around her.

Media Cutscene with it being gone https://cdn.discordapp.com/attachments/885758931803193344/945882115147448330/GlowGone_SF16.mp4

Cutscene with it being there https://youtu.be/7yzByD7_v9g?t=1426 (23:47)

Platform (please complete the following information): All

Game Version: 1.5.5

Additional context Discovered by Monody in Discord: https://discord.com/channels/297870727422541826/885758931803193344/945882115847905300

Jesright73 commented 1 year ago

Fix for this issue: oSuitChangeFX step event

if (state == 3)
{
    if (bg3alpha < 1)
        bg3alpha += 0.05;
    else
    {
        state = 4;
        bg3alpha = 1;
        bg1alpha = 0;
        if instance_exists(oFakeItemBall)
        {
            with (oFakeItemBall)
                instance_destroy();
        }
+       instance_create(x, y, oSuitChangeFX2);
        if (global.SuitChangeGravity == 0)
            scr_variasuitswap();
        else
            global.currentsuit = 2;
    }
}
Jesright73 commented 1 year ago

There is also a mistake in the create event of oSuitChangeFX2 image_index is used where sprite_index should be.

gml_Object_oSuitChangeFX2_Create_0

if (oControl.mod_fusion == 1)
-    image_index = 1133
+    sprite_index = sSuitChangeFX2_fusion 
alarm[0] = 60