search

AM2R-Community-Developers / AM2RLauncher

Host respository for the AM2RLauncher.
GNU General Public License v3.0
348 stars 19 forks source link

Use proper directories for fetched files on unix #14

Closed IvarWithoutBones closed 2 years ago

IvarWithoutBones commented 3 years ago

Currently, the launcher attempts to write some patches, and a github repository to the directory the executable is placed in.

This results in the application being impossible to package, as you do not want to pollute (for example) /usr/bin. This is especially required for NixOS support, for which I've written an derivation. It currently crashes as it tries to write to the nix store, which is not meant to be modified by applications other than the package manager.

I suggest $HOME/.local being used for these, or alternatively /tmp.

Miepee commented 3 years ago

Pushed Commit db77e29, tell me if this works for you and if you have any issues. The tldr; of that commit is, all operations that were done to CWD are not being done to ~/.local/share instead. the log4net.config is also now not included into Linux builds (they are still for Windows), but instead automatically generated in the same Path if it doesn't exist.

Miepee commented 2 years ago

Has been fixed