search

AM2R-Community-Developers / AM2RLauncher

Host respository for the AM2RLauncher.
GNU General Public License v3.0
365 stars 19 forks source link

Allow overriding NOAUTOUPDATE during the build #47

Closed clhodapp closed 1 year ago

clhodapp commented 1 year ago

Even though there's a preprocessor conditional in the code to allow distro packagers to disable auto-updating, it cannot be easily accessed unless it's bound through in the csproj file.

On my Linux machine, this allows me to pass a --property:NoAutoUpdate=true flag to dotnet to disable autoupdate.

Miepee commented 1 year ago

Hi, thanks for the PR! I'm a bit confused however, why this is needed. It's already possible to change the flag without editing source, by just doing dotnet publish -p:DefineConstants=\"NOAUTOUPDATE\" (our flatpak build does that for example). So why should there be a second way to change those flags?

clhodapp commented 1 year ago

Sure enough, that works! Thanks!