search

AM2R-Community-Developers / AM2RLauncher

Host respository for the AM2RLauncher.
GNU General Public License v3.0
343 stars 19 forks source link

Fix OpenSSL-related crash for 1.6 beta users #59

Closed peeley closed 4 months ago

peeley commented 8 months ago

This change clears the version requirement on the X509_free symbol linked to by the .runner-unwrapped binary via patchelf. This allows the game to run without crashing on startup when using the 64-bit 1.6 beta mod.

This change should only affect users using both the NOAPPIMAGE and PATCHOPENSSL build flags.

This change was previously discussed in https://github.com/AM2R-Community-Developers/AM2RLauncher/issues/56.

Miepee commented 8 months ago

reposting this here, would be neat if someone were still able to test this:

here's the server and client for miles' last multitroid version. Ideally run the server on a machine of yours (you probably need to manually patch the binary to get rid of openssl), then have two machines with patched openssl try to connect to it. I'll see if i can make that version go through the 1.6 scripts to have a 64bit PoC. If yes, i'll go post that in here (or in the PR if its made) and ask for another test run by you.

Miepee commented 4 months ago

Merging, as that probably helps with testing the above mentioned. TY again for the patches!

peeley commented 3 months ago

My pleasure! For parity between the launcher and patcher, https://github.com/AM2R-Community-Developers/AM2R-Autopatcher-Linux/pull/37 may also need to be merged as well.

Also, just curious - does this change (or the last few changes cumulatively) qualify for a new release tag, say v2.3.1? Or is that done on an ad hoc basis?

Miepee commented 3 months ago

we're having a few other blockers before we can do a new release.