Add Portuguese Translation

AM2R-Community-Developers / AM2RLauncher

Host respository for the AM2RLauncher.

GNU General Public License v3.0

348 stars 19 forks source link

Add Portuguese Translation #6

Closed LiveLM closed 3 years ago

LiveLM commented 3 years ago

This pull request adds a Portuguese Translation into the launcher. Should be adequate for both Brazilian Portuguese and European Portuguese, but @peachflavored, please tell me if you find anything unusual or weird. Spreadsheet with all the strings for easy viewing.

peachflavored commented 3 years ago

All seems fine by me. I might need help with merging my translation with the official AM2R translations by creating a pull request since I'm new to this GitHub thing and can't seem to do it by myself.

Miepee commented 3 years ago

So, if I see this correctly, this was already proof-read by: Live (brazilian) Chico (brazilian) Tally (brazilian) PeachFlavored (portugal)

@peachflavored do you have connections to Katherine_S2003? Could you ask them if they could proof-read over it as well? Otherwise looks good to me then,

I might need help with merging my translation with the official AM2R translations by creating a pull request since I'm new to this GitHub thing and can't seem to do it by myself.

A bit offtopic, but the way this works is:

Fork the AM2R-Localizations repo (which you already seem to have done)
Add your portguese.ini in there
click on the "Pull Request" Tab, and then "Create new Pull Request"

peachflavored commented 3 years ago

@Miepee I already contacted her about this and I'm waiting for a response but I'm safe to say that the translation is good. Also thanks for helping me out with the Pull Request stuff.

Lojemiru commented 3 years ago

Cool, that's plenty of reviewers for me to feel safe merging this. Feel free to open issues or another PR should you notice anything that was missed :)

peachflavored commented 3 years ago

I've spoke to Katherine_S2003 and she agreed to have her username added to the list of proof-readers of my translation.

Miepee commented 3 years ago

I've spoke to Katherine_S2003 and she agreed to have her username added to the list of proof-readers of my translation.

Wait, is this referring to this PR for the Launcher, or the other PR regarding AM2R-Portguguese?

peachflavored commented 3 years ago

@Miepee the PR referring to the European Translation for the game. I didn't spoke about the Launcher's translation since 4 people should be good enough being 3 of them Brazilians. :)

Miepee commented 3 years ago

Ah. Well, post PR comments then to their respective PR, makes it easier to keep track of.