search

AM2R-Community-Developers / AM2RLauncher

Host respository for the AM2RLauncher.
GNU General Public License v3.0
348 stars 19 forks source link

Moved SPLASH_LIST to a seperate file #9

Closed troy0h closed 2 years ago

troy0h commented 3 years ago

This should help clean up the MainForm.UI file a bit

Miepee commented 3 years ago

Looks good to me now.

Lojemiru commented 3 years ago

Hey! I really like the idea here, but the implementation doesn't go as far as it should towards abstraction. The splash list's calculation for Gtk-specific splashes should be offloaded to that class instead of being handled while getting the list. Ideally it'd just be a Splash.GetSplash() method that returns one chosen based on the current platform.

troy0h commented 3 years ago

This won't build at the moment, due to an issue with Platform.IsGtk that I can't seem to figure out

troy0h commented 3 years ago

GetSplash method is now working, and I also split the array, as Miepee asked, so it should be easier to add new splash text in the future

Miepee commented 3 years ago

Added some documentation and made the Splash class static, so it's not necessary anymore now to create an instance of it.

Lojemiru commented 2 years ago

This all checks out, sorry for the delay in getting to merging this.