Increase the Set Ras Oob Config retries

[AMD Official Use Only - General]

Can’t we just increase the retry count instead of changing the time to sleep? It would work for both, I guess.

Mahesh

From: abinayaddhandapani @.> Sent: Monday, November 20, 2023 10:44 PM To: AMDESE/amd-bmc-ras @.> Cc: Kurapati, Mahesh @.>; Review requested @.> Subject: Re: [AMDESE/amd-bmc-ras] Increase the Set Ras Oob Config retries (PR #76)

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

@abinayaddhandapani commented on this pull request.

In src/runtime_errors.cpphttps://github.com/AMDESE/amd-bmc-ras/pull/76#discussion_r1400021464:

@@ -58,7 +58,7 @@ oob_status_t SetOobConfig()

     oob_config.pcie_err_reporting_en = ENABLE_BIT;

 }

uint16_t retryCount = 30;
uint16_t retryCount = 45;

Hi Mahesh. We are sending SetRasOobConfig command every 20 second until the command succeeds. Once the command is successful, the module starts the RAS functionality. For 1P system it takes around 180 seconds (9 retries for every 20 seconds ) and 600 seconds for 2P system (Around 30 retries for every 20 seconds) for the command to be successful. As it takes anywhere from 3 to 15 minutes for the PCIE AER to be enabled , I have used retries for every 20 seconds.

— Reply to this email directly, view it on GitHubhttps://github.com/AMDESE/amd-bmc-ras/pull/76#discussion_r1400021464, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCUUIJQJ7LQOY333XTI3K2LYFQWPTAVCNFSM6AAAAAA7SI6LXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBRGEYDQNJSGA. You are receiving this because your review was requested.Message ID: @.**@.>>

AMDESE / amd-bmc-ras

Increase the Set Ras Oob Config retries #76