AMDResearch / Riallto

The Riallto Open Source Project from AMD

https://riallto.ai

Other

69 stars 10 forks source link

Improve logic for `MTSplit` #66

Closed mariodruiz closed 1 month ago

mariodruiz commented 1 month ago

Describe the problem solved by the commit

Double tracing the app leads to error as discussed in #63 for non anonymous kernels.

How is the problem solved?

Caching the original tracing of the application.
Added extensive testing with multiple MTSplit scenarios, different datatypes and sizes.
Raise an error when the split type is not supported to avoid cryptic message such as '<' not supported between instances of 'NoneType' and 'NoneType'

Are there any risks associated to the change?

No

Is there a documentation impact?

No

Checklist

[x] I added a test to cover my changes
[x] Existing and new test pass
[x] I read and I accept the CONTRIBUTING.md guidelines

Please provide screenshots (if applicable)

Related issues

63