Windrose - Githubissues

FarishtaRahman commented 3 months ago

-developed windrose code

PR Self Evaluation

[x] I have reviewed my code to check that it contains no sensitive information.
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests or modified existing tests that prove my fix is effective or that my feature works
[x] Existing unit tests pass locally with my changes

FarishtaRahman commented 3 months ago

I have added the new directory for saved outputs like — Site_id — BASE — version
— FLUXNET — version

yocheah commented 3 months ago

Go ahead and remove requirements.txt

yocheah commented 3 months ago

There is a better way of doing that comparison. The total may come out as 99.9999 given the current comparison.

On Thu, Aug 15, 2024 at 9:35 PM FarishtaRahman @.***> wrote:

@.**** commented on this pull request.

In windrose/windrose.py https://github.com/AMF-FLX/AMF-BASE-QAQC/pull/113#discussion_r1719287172 :

+

speed = season_df['speed'].to_numpy().reshape(-1, 1)

direction = season_df['direction'].to_numpy().reshape(-1, 1)

dirc = np.mod((self.north - direction) / (

self.north - self.east) * 90, 360)

dirc = dirc[speed.flatten() > 0]

speed = speed[speed.flatten() > 0]

if len(vwinds) > 0 and vwinds[0] != 0:

vwinds = np.insert(vwinds, 0, 0)

count_df = self.generate_frequency_table(

ndirections, vwinds, speed, dirc, direction)

if 99.9999 <= count_df.iloc[-1, -1] < 100.0001:

This is written for checking if the total comes as 100%.

— Reply to this email directly, view it on GitHub https://github.com/AMF-FLX/AMF-BASE-QAQC/pull/113#discussion_r1719287172, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAUNIVFA6J6ULHVNXYITYLZRV6SPAVCNFSM6AAAAABMI4EJH6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBRG44DCMRRG4 . You are receiving this because your review was requested.Message ID: @.***>

AMF-FLX / AMF-BASE-QAQC

Windrose #113

PR Self Evaluation

@.**** commented on this pull request.