search

AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
108 stars 30 forks source link

Allow setting MaxConvFails and MaxNonlinIters on solvers #2335

Closed dweindl closed 6 months ago

dweindl commented 6 months ago

See CVodeSetMaxConvFails and CVodeSetMaxNonlinIters.

Closes #2333.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 77.90%. Comparing base (4782cad) to head (954e523).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2335 +/- ## =========================================== + Coverage 77.88% 77.90% +0.01% =========================================== Files 324 324 Lines 20680 20723 +43 Branches 1440 1448 +8 =========================================== + Hits 16107 16144 +37 - Misses 4570 4576 +6 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `73.70% <86.95%> (+0.02%)` | :arrow_up: | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `34.35% <26.08%> (-0.02%)` | :arrow_down: | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `36.87% <22.72%> (-0.04%)` | :arrow_down: | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `72.47% <67.39%> (-0.02%)` | :arrow_down: | | [sbmlsuite](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [include/amici/serialization.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9zZXJpYWxpemF0aW9uLmg=) | `96.65% <100.00%> (+0.03%)` | :arrow_up: | | [include/amici/solver.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9zb2x2ZXIuaA==) | `100.00% <ø> (ø)` | | | [include/amici/solver\_cvodes.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9zb2x2ZXJfY3ZvZGVzLmg=) | `100.00% <ø> (ø)` | | | [include/amici/solver\_idas.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9zb2x2ZXJfaWRhcy5o) | `100.00% <ø> (ø)` | | | [src/hdf5.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL2hkZjUuY3Bw) | `89.80% <100.00%> (+0.15%)` | :arrow_up: | | [src/newton\_solver.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL25ld3Rvbl9zb2x2ZXIuY3Bw) | `70.63% <100.00%> (-0.24%)` | :arrow_down: | | [src/solver.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NvbHZlci5jcHA=) | `75.45% <88.23%> (+0.23%)` | :arrow_up: | | [src/solver\_cvodes.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NvbHZlcl9jdm9kZXMuY3Bw) | `69.51% <75.00%> (+0.07%)` | :arrow_up: | | [src/solver\_idas.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NvbHZlcl9pZGFzLmNwcA==) | `37.09% <75.00%> (+0.55%)` | :arrow_up: |