Closed dweindl closed 6 months ago
Attention: Patch coverage is 95.23810%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 77.64%. Comparing base (
19f7baf
) to head (c0092c7
). Report is 3 commits behind head on develop.
On second thought, maybe add the libsbml parser settings as module variable and import rather than duplicating?
On second thought, maybe add the libsbml parser settings as module variable and import rather than duplicating?
Would like to, but it takes a specific model as first argument. The best thing I could do, would be adding a function that creates a parser, I think, to not duplicate the settings.
During PEtab import, parameters that are targets of initial assignments have so far not been turned into constant parameters, because they didn't exist in the amici model (see #2304). Now that those parameters remain in the model, they should be turned into constant parameters, unless specified otherwise.
Requires https://github.com/PEtab-dev/libpetab-python/pull/248, otherwise PEtab parameter mapping will provide potentially incorrect values for those parameters.