search

AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
108 stars 30 forks source link

Add Solver::get_current_time #2346

Closed dweindl closed 6 months ago

dweindl commented 6 months ago

... to get the current integration time from the solver.

(also fixes a couple of incorrect exception types and messages)

Prerequisite for #2246.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 77.81%. Comparing base (e8852be) to head (fac4795).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2346 +/- ## =========================================== - Coverage 77.88% 77.81% -0.07% =========================================== Files 324 324 Lines 20731 20745 +14 Branches 1449 1453 +4 =========================================== - Hits 16146 16143 -3 - Misses 4582 4599 +17 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `73.61% <0.00%> (-0.07%)` | :arrow_down: | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `34.32% <0.00%> (-0.03%)` | :arrow_down: | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `36.82% <0.00%> (-0.04%)` | :arrow_down: | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `72.39% <0.00%> (-0.06%)` | :arrow_down: | | [sbmlsuite](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [include/amici/solver.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9zb2x2ZXIuaA==) | `100.00% <ø> (ø)` | | | [include/amici/solver\_cvodes.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9zb2x2ZXJfY3ZvZGVzLmg=) | `100.00% <ø> (ø)` | | | [include/amici/solver\_idas.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9zb2x2ZXJfaWRhcy5o) | `100.00% <ø> (ø)` | | | [src/solver\_cvodes.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NvbHZlcl9jdm9kZXMuY3Bw) | `69.01% <0.00%> (-0.51%)` | :arrow_down: | | [src/solver\_idas.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NvbHZlcl9pZGFzLmNwcA==) | `36.63% <0.00%> (-0.46%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2346/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)
dweindl commented 6 months ago

Wait, there is already Solver::gett. This should produce the same results.