AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
108 stars 30 forks source link

Always include timepoints in NaN/Inf warnings #2347

Closed dweindl closed 6 months ago

dweindl commented 6 months ago

Closes #2328

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 12.50000% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 36.79%. Comparing base (e8852be) to head (2deb567). Report is 2 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2347 +/- ## ============================================ - Coverage 77.88% 36.79% -41.09% ============================================ Files 324 103 -221 Lines 20731 14711 -6020 Branches 1449 1373 -76 ============================================ - Hits 16146 5413 -10733 - Misses 4582 8992 +4410 - Partials 3 306 +303 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `36.79% <12.50%> (-0.07%)` | :arrow_down: | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | | [sbmlsuite](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [include/amici/model.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9tb2RlbC5o) | `36.84% <ø> (-36.85%)` | :arrow_down: | | [src/amici.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL2FtaWNpLmNwcA==) | `35.29% <100.00%> (-45.79%)` | :arrow_down: | | [src/model\_dae.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL21vZGVsX2RhZS5jcHA=) | `0.00% <0.00%> (-31.17%)` | :arrow_down: | | [src/model\_ode.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL21vZGVsX29kZS5jcHA=) | `37.15% <0.00%> (-28.90%)` | :arrow_down: | | [src/solver\_cvodes.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NvbHZlcl9jdm9kZXMuY3Bw) | `21.85% <12.50%> (-47.67%)` | :arrow_down: | | [src/solver\_idas.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NvbHZlcl9pZGFzLmNwcA==) | `0.00% <0.00%> (-37.10%)` | :arrow_down: | | [src/model.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL21vZGVsLmNwcA==) | `34.52% <18.51%> (-51.73%)` | :arrow_down: | ... and [282 files with indirect coverage changes](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2347/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)