search

AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
108 stars 31 forks source link

ReturnData: remove protected data members #2348

Closed dweindl closed 2 weeks ago

dweindl commented 7 months ago

Currently, ReturnData has a number of protected data members that are used as temporary storage for model quantities during collecting the output data. It's currently rather intransparent which values are used when. They also waste some memory. I'd suggest to remove them and rather pass SimulationState through a couple of functions.

dweindl commented 3 weeks ago

Another motivation for their removal is to get all sundials objects out of ReturnData, so we don't have to worry about managing SUNContext outside of runAmiciSimulation with sundials>=6.0.