AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
108 stars 30 forks source link

Fix initial state issues with PEtab #2382

Closed dweindl closed 5 months ago

dweindl commented 5 months ago
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 76.26%. Comparing base (41b4ce4) to head (1bcbf32).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2382 +/- ## =========================================== - Coverage 77.68% 76.26% -1.43% =========================================== Files 324 319 -5 Lines 20869 20711 -158 Branches 1458 1458 =========================================== - Hits 16213 15796 -417 - Misses 4653 4911 +258 - Partials 3 4 +1 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `73.45% <0.00%> (-0.02%)` | :arrow_down: | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `34.21% <0.00%> (-0.01%)` | :arrow_down: | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `72.22% <0.00%> (-0.02%)` | :arrow_down: | | [sbmlsuite](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [python/sdist/amici/petab/sbml\_import.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL3BldGFiL3NibWxfaW1wb3J0LnB5) | `28.16% <0.00%> (-26.77%)` | :arrow_down: | | [python/sdist/amici/petab/parameter\_mapping.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL3BldGFiL3BhcmFtZXRlcl9tYXBwaW5nLnB5) | `52.63% <0.00%> (-28.12%)` | :arrow_down: | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2382/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)