AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
107 stars 30 forks source link

Fix incorrect exception types / messages for IDASolver #2398

Closed dweindl closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 76.27%. Comparing base (d993362) to head (93f26a6).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2398 +/- ## =========================================== - Coverage 77.69% 76.27% -1.43% =========================================== Files 324 319 -5 Lines 20875 20714 -161 Branches 1458 1456 -2 =========================================== - Hits 16219 15799 -420 - Misses 4653 4911 +258 - Partials 3 4 +1 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `73.45% <0.00%> (ø)` | | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `34.21% <0.00%> (ø)` | | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `72.23% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [src/solver\_idas.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398?src=pr&el=tree&filepath=src%2Fsolver_idas.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NvbHZlcl9pZGFzLmNwcA==) | `37.69% <0.00%> (ø)` | | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2398/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)