search

AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
107 stars 30 forks source link

More comprehensive/robust conversion of docstring type/rtype to type … #2401

Closed dweindl closed 3 months ago

dweindl commented 3 months ago

…annotations

Should cover everything currently present in amici.py, except for overloaded methods.

Exclude two methods from swig interface that aren't easily usable from Python.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 75.92%. Comparing base (6bbcde2) to head (de8a635).

:exclamation: Current head de8a635 differs from pull request most recent head db700e5. Consider uploading reports for the commit db700e5 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2401 +/- ## =========================================== - Coverage 78.29% 75.92% -2.38% =========================================== Files 324 324 Lines 20875 20894 +19 Branches 1458 1450 -8 =========================================== - Hits 16345 15864 -481 - Misses 4527 5027 +500 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `73.39% <15.62%> (-0.68%)` | :arrow_down: | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `?` | | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `36.78% <15.62%> (-0.04%)` | :arrow_down: | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `69.82% <15.62%> (-3.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [python/sdist/amici/swig.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fswig.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL3N3aWcucHk=) | `12.50% <15.62%> (+1.97%)` | :arrow_up: | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2401/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)